gianfrdp / SDM120C

sdm120c ModBus Mini Smart Meter
GNU General Public License v2.0
73 stars 37 forks source link

error when compiled #19

Open wifi75 opened 4 years ago

wifi75 commented 4 years ago

hello on ubuntu server after send command make clean && make I get this error:

rm -f *.o sdm120c
gcc -c -o sdm120c.o sdm120c.c -O2 -Wall -g `pkg-config --cflags libmodbus`
sdm120c.c: In function ‘log_message’:
sdm120c.c:264:24: warning: format not a string literal and no format arguments [-Wformat-security]
        fprintf(stderr, buffer);
                        ^~~~~~
sdm120c.c:273:30: warning: format not a string literal and no format arguments [-Wformat-security]
             syslog(LOG_INFO, versionbuffer);
                              ^~~~~~~~~~~~~
sdm120c.c:276:30: warning: format not a string literal and no format arguments [-Wformat-security]
             syslog(LOG_INFO, parent);
                              ^~~~~~
sdm120c.c:277:30: warning: format not a string literal and no format arguments [-Wformat-security]
             syslog(LOG_INFO, cmdline);
                              ^~~~~~~
sdm120c.c:280:26: warning: format not a string literal and no format arguments [-Wformat-security]
         syslog(LOG_INFO, buffer);
                          ^~~~~~
gcc -o sdm120c sdm120c.o -O2 -Wall -g `pkg-config --libs libmodbus`
chmod 4711 sdm120c

what can I do?

ehoutsma commented 4 years ago

sudo make install?

I don't see any errors, only warnings.

asarubbo commented 10 months ago

With the updated version I think there is still an issue here: https://github.com/gianfrdp/SDM120C/blob/f36fb38c2f8985e2330ed2492178211d63542361/sdm120c.c#L279