search

gianni-rosato / aviator

A lightweight, Flatpak-first, easy-to-use GUI utility for encoding with SVT-AV1 & Opus.
GNU General Public License v3.0
156 stars 14 forks source link

Add German translation #69

Closed SebinNyshkim closed 2 months ago

SebinNyshkim commented 2 months ago

This adds German as an additional language for Aviator.

One thing I noticed is that the deinterlace toggle isn't translatable. Even if I put in a translation manually (it's missing in the POT file) it won't get picked up properly. The toggle itself is translatable, the tooltip however is not. The encoding progress label above the progress bar also doesn't pick up translations for some reason. If someone more knowledgeable than me knows how to fix this, my translations should get picked up automatically.

The notification after encoding is done still shows the elapsed time in English. Localizing that is a little more involved. humanize supports i18n methods, but I don't know Python so I'd rather not mess with the code :)

Some translations also barely fit the widgets they're put in. German is notorious for its long words and I had to get a little creative so it doesn't break the GUI (e.g. "Perceptual Tuning" -> "Bildoptimierung", lit. "image optimization" because "Wahrnehmungsabstimmung" caused the CRF label to be hyphenated, which looked goofy :upside_down_face:). The only place where that didn't work was the label for the audio volume slider, which gets hyphenated next to the normalize toggle due to a lack of space. That could be avoided by increasing the default window size, tho.

gianni-rosato commented 2 months ago

Thanks for this - LGTM!

I'll pull in @yakushabb regarding the missing untranslatable portions - I'm not super familiar with the translation system.

yakushabb commented 2 months ago

Could you merge this PR. I will test the issue later. Could you open one. Thanks.