gid-oss / dataui-nestjs-crud

NestJs CRUD for RESTful APIs
https://github.com/nestjsx/crud/wiki
MIT License
130 stars 31 forks source link

Fix: duplicate column selection issue in getMany with joins and pagination #33

Closed ZaidMaslouhi closed 8 months ago

ZaidMaslouhi commented 8 months ago

This pull request proposes a fix for the duplicate column names encountered when using getMany with joins and pagination in NestJS CRUD #788.

The current solution in #788 excludes the "id" column, which might not be ideal for all relational scenarios. This pull request aims to address duplication directly within the column array, preserving the "id" column when necessary or any duplicated column.

Key points:

Please review and provide feedback on the proposed approach.

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 8365400820

Details


Totals Coverage Status
Change from base Build 8258247547: 0.0%
Covered Lines: 1244
Relevant Lines: 1251

💛 - Coveralls