search

gilmaimon / ArduinoWebsockets

A library for writing modern websockets applications with Arduino (ESP8266 and ESP32)
GNU General Public License v3.0
482 stars 97 forks source link

Add support for Teensy 4.1 #93

Closed arnoson closed 4 years ago

arnoson commented 4 years ago

I got the Teensy 4.1 working using it's NativeEthernet library It was really a joy working with your well written code! WSS is currently not implemented, but it should be possible (NativeEthernet seems to supports it) I also added some basic examples and also a more complex one: setting up a http server and a websocket server at the same time with the http server providing a website to connect to the websockets server (This is the use case for which I initially looked into your library)

gilmaimon commented 4 years ago

Awesome!!!

Thank you for the kind words and awesome contribution! I love the examples and the fact you managed to add the new platform code without any help, and that you took the time to write everything and create a pull request.

You are a hero! Merged 👍

Thanks again.

arnoson commented 4 years ago

I'm glad you like the contribution, thank you for your awesome work on this libray!! I just realised that in the about description the Teensy 4.1 is missing and there is one thing I forgot to change in the readme:

A library for writing modern websockets applications with Arduino (ESP8266 and ESP32).

Maybe we change it to something like this?

A library for writing modern websockets applications with Arduino (see [prerequisites](https://github.com/gilmaimon/ArduinoWebsockets#prerequisites)).

So in the future there is only one place (and the about description) to add the new boards.

gilmaimon commented 3 years ago

(see prerequisites).

I completely missed this comment! My bad, but I refactored the README.md now :)