Skip the EC Symbol Map when parsing COFF archives

gimli-rs / object

A unified interface for reading and writing object file formats

https://docs.rs/object/

Apache License 2.0

673 stars 157 forks source link

Skip the EC Symbol Map when parsing COFF archives #669

Closed dpaoliello closed 7 months ago

dpaoliello commented 7 months ago

Arm64EC introduced a new special member in COFF called /<ECSYMBOL>/ which contains the symbol table for EC-specific symbols: https://github.com/llvm/llvm-project/blob/1aceee7bb6c4423da73f71aff2004493bdf620d1/llvm/lib/Object/ArchiveWriter.cpp#L647

When parsing an archive, object should skip over this member.

philipc commented 7 months ago

Is this related to the change in #657? I guess before it would have returned an empty name for this?

dpaoliello commented 7 months ago

Is this related to the change in #657? I guess before it would have returned an empty name for this?

No, not related: with or without #657, this is a special member automatically generated by the archiver which should have been skipped, but I missed doing this with my initial Arm64EC support because I didn't realize that object supported reading archives.