gimli-rs / object

A unified interface for reading and writing object file formats
https://docs.rs/object/
Apache License 2.0
673 stars 156 forks source link

Release 0.36.4 #724

Closed philipc closed 2 months ago

marxin commented 2 months ago

Btw. I tried building the current main branch of the Wild linker and I met the following warning:

warning: associated function `new` is never used
   --> /home/marxin/Programming/object/src/read/mod.rs:600:8
    |
599 | impl<'data> ObjectMapFile<'data> {
    | -------------------------------- associated function in this implementation
600 |     fn new(path: &'data [u8], member: Option<&'data [u8]>) -> Self {
    |        ^^^
    |
    = note: `#[warn(dead_code)]` on by default

Is it something expected or did I mess something?

marxin commented 2 months ago

Got it, it's related to the fact that wild does not use macho feature flag, which is the only place that uses the new function.

philipc commented 2 months ago

Thanks for pointing that out.