search

gini / gini-mobile-ios

Monorepo for Gini iOS SDKs
Other
6 stars 2 forks source link

Pia 4098 drag to dismiss edit article modal screen UI layout issues #386

Closed ValentinaIancu-Gini closed 1 year ago

zladzeyka commented 1 year ago

IMG_C7748E7EE236-1 Please add the same inset for the Quantity value that you have for Unit price

zladzeyka commented 1 year ago

https://github.com/gini/gini-mobile-ios/assets/3911816/544fbd4b-162e-4d22-806e-8c171ab057c7

I've noticed one small layout issue if we rotate the screen and drag the presented screen up a bit, the screen will not update layout and going under the keyboard

ValentinaIancu-Gini commented 1 year ago

RPReplay_Final1689088402.MP4 I've noticed one small layout issue if we rotate the screen and drag the presented screen up a bit, the screen will not update layout and going under the keyboard

Related to this, this is not something affected by these current changes :|. I've tested on the main branch and is also happening.

https://github.com/gini/gini-mobile-ios/assets/132361182/c23c82a6-e935-403d-aebb-5efe0b9c9bb3

Do you want me to fix it in my pr? Or should we create a separate ticket for this?

zladzeyka commented 1 year ago

RPReplay_Final1689088402.MP4 I've noticed one small layout issue if we rotate the screen and drag the presented screen up a bit, the screen will not update layout and going under the keyboard

Related to this, this is not something affected by these current changes :|. I've tested on the main branch and is also happening.

Simulator.Screen.Recording.-.iPad.Air.2.-.2023-07-11.at.18.00.43.mp4

Do you want me to fix it in my pr? Or should we create a separate ticket for this?

It will be a separate ticket

ValentinaIancu-Gini commented 1 year ago

RPReplay_Final1689088402.MP4 I've noticed one small layout issue if we rotate the screen and drag the presented screen up a bit, the screen will not update layout and going under the keyboard

Related to this, this is not something affected by these current changes :|. I've tested on the main branch and is also happening. Simulator.Screen.Recording.-.iPad.Air.2.-.2023-07-11.at.18.00.43.mp4 Do you want me to fix it in my pr? Or should we create a separate ticket for this?

It will be a separate ticket

I will create a ticket for this!