Syntax adjustments to avoid editor highlighting bugs

gisle / tcl.pm

Tcl extension module for Perl

http://search.cpan.org/dist/Tcl

9 stars 8 forks source link

Syntax adjustments to avoid editor highlighting bugs #20

Closed chrstphrchvz closed 5 years ago

chrstphrchvz commented 5 years ago

This commit uses functionally-equivalent syntax to avoid triggering syntax highlighting bugs in TextMate and any editors/IDEs reusing its rules (e.g. Atom and VS Code).

There's a few highlighting bugs (some specifically for Perl regex) already reported a while ago, but I haven't found if any of those are what Makefile.PL were triggering: https://github.com/textmate/perl.tmbundle/issues

chrstphrchvz commented 5 years ago

Some screenshots of the issues:

screen shot 2018-11-11 at 2 11 47 am

screen shot 2018-11-11 at 2 12 16 am

screen shot 2018-11-11 at 2 12 43 am

vadrer commented 5 years ago

thank you, looks good

chrstphrchvz commented 5 years ago

https://github.com/textmate/perl.tmbundle/issues/25: another workaround would have been to put a space between regex /^MSWin32|…|openbsd$/ and ternary operator ? 1 : 0.