search

gita / gita-frontend-v2

Frontend for BhagavadGita.io v2
https://bhagavadgita.io
MIT License
43 stars 53 forks source link

[BUG] Color buttons in appearance setting not working #231

Closed shantanusoni72 closed 10 months ago

shantanusoni72 commented 1 year ago

🙁 Actual behavior

These color buttons are not working except black button. image

🙂 Expected behavior

It should change the theme as according to color selected.

🔢 Steps to Reproduce the Problem

  1. Go to any chapter page.
  2. Click at Appearance Settings
  3. Select either white or light yellow color and apply
  4. Nothing happens
PALLAVIKHEDLE commented 1 year ago

Can you please assign this issue to me?

shantanusoni72 commented 1 year ago

Can you please assign this issue to me?

Yes.

shantanusoni72 commented 1 year ago

According to their business logic, the dark theme is activated when setTheme('dark') is executed with the 'bg-dark-bg' value matched otherwise it will activate the light theme by default. This is because they are using default themes of the next-theme library for applying themes. I wonder if I remove the yellow button then this issue can be resolved. Should I do it?

Is it good enough? image