search

githedgehog / dataplane

The hedgehog dataplane
Apache License 2.0
2 stars 1 forks source link

Hardcoded paths in `.cargo/config.toml` #1

Closed qmonnet closed 2 weeks ago

qmonnet commented 2 months ago

Two occurrences of /home/dnoland/ are present in the cargo config file and need to be changed to something more generic, at some point.

rustflags = [
    "-C", "linker=clang",
    "-C", "link-arg=-fuse-ld=lld",
    "-C", "link-arg=--ld-path=/home/dnoland/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin/gcc-ld/ld.lld",
qmonnet commented 2 months ago

Looks tricky though, it seems you can't pass any env variable through the config.toml at the moment. I've used /root/.rustup/... for the dev container so far, for what it matters.

daniel-noland commented 2 months ago

Yeah, this is one of the things I'm working on to get this out of the "scratch" phase.

I think we just need to set RUSTFLAGS in a build script because config.toml just isn't going to work as far as I can see.

It is quite annoying because this leaves us with a harder IDE dev integration flow.

daniel-noland commented 2 months ago

(sorry, closed issue by mistake)

daniel-noland commented 2 weeks ago

Closing with #21 resolved