Concerns about -prepareForReuse in RBLTableCellView

[jwilling]

I'll tread lightly here due to NDA, but I think this is important to get figured out before [Sea Lion] is released.

In RBLTableCellView I added a -prepareForReuse method, which is called when the superview changes. This is all fine and dandy, except for the fact that apparently this method has already existed since 10.7 on NSView, and has just been made public.

I have done no actual testing of this, however from just introspection it seems like this might be a potential concern.

[jspahrsummers]

Let's rename it, intentionally as a breaking change.

[jwilling]

Any suggestions on a new method name? Just to throw a couple out there:

• -prepareForDequeue
• -readyForReuse (don't like this much at all)
• -prepareForDisuse

I believe we already went over some names in the previous thread where this was originally created as well.

[alanjrogers]

-rbl_prepareForReuse

[dannygreg]

Yeah let's just have a prefix.

[jwilling]

I'll be happy to make a pull request for this.

Also, here's another thought. What about just removing this class and just adding a category that declares the method so people can just use the built-in method? Alternatively, we could still have a prefixed method that is called internally from the system's implementation.

[jspahrsummers]

I can't actually find any confirmation that -prepareForReuse is a thing now. Wasn't able to find it in a header or in the docs for the 10.9 SDK.

In any case:

What about just removing this class and just adding a category that declares the method so people can just use the built-in method?

Only if it's explicitly documented to have existed since 10.7.

[jwilling]

In NSView.h:

/* The View Based NSTableView allows views to be reused. Sometimes it is necessary to 
prepare a view with some initial state before it is to be reused. This method can be overridden 
to allow a view to be prepared back to the default state. Override this method to do the 
preparation. By default, NSView will do some setup, such as setting the view to not be
hidden and have a 1.0 alpha. It is important to call super to get this work done. This method 
was made public in 10.9, but exists back to 10.7.
 */
- (void)prepareForReuse NS_AVAILABLE_MAC(10_7);

(feel free to delete this if you think it's violating NDA)

[jspahrsummers]

lol, NSView.

[jwilling]

Yeah pretty classic.

[indragiek]

:+1:

[jwilling]

So, what's the consensus? Here are our options:

• Remove the subclass in favor of a header that declares the method
• Prefix the current method

[jspahrsummers]

Prefix the current method, to avoid breakage when super isn't called like the official method expects. However, we should document that they can use -prepareForReuse instead.

[jwilling]

:+1: