Fix Issue147 - problems with save/load mirror configuration json file

githubdoe / DFTFringe

DFTFringe Telescope Mirror interferometry analysis Program.

GNU General Public License v3.0

168 stars 59 forks source link

Fix Issue147 - problems with save/load mirror configuration json file #154

Closed gr5 closed 4 months ago

gr5 commented 4 months ago

One of the bugs had to do with a maximum value of 1000 for the annulus diameter. I raised that to 10000 (10 meter mirrors max for hole in mirror) Another was that as you switched between inches and mm the annulus diameter value kept growing.

Fix #147

gr5 commented 4 months ago

Fixes issue #147

atsju commented 4 months ago

Fixes issue #147

Only for info : This won't auto close. You need either "fix #147" or "fixes #147" and it must be written in a commit message or in the top comment/description of the PR. I edited it for you

gr5 commented 4 months ago

Oops. I forgot to checkout master before I did the "git checkout -b issue153". Thanks for the warning. Thanks for the help, both of you.