githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure
https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

Step 5: The auto generated spinup-destroy.yml file is incorrect #37

Open mickeygousset opened 4 years ago

mickeygousset commented 4 years ago

Describe the bug In Step 5: Spin up, configure, and destroy Azure Resources, the autogenerated spinup-destroy.yml file does not match the code listed in the lab after substep 12.. The code in the autogenerated file is wrong, and the lab will fail if it is used. The lab does not explicitly tell you to replace the code, implying that you should use the autogenerated code.

Specifically, the Configure Webapp to use GitHub Packages action script is different between the two. The one listed in the lab is correct. The autogenerated code is wrong.

To Reproduce Steps to reproduce the behavior:

  1. Start the lab
  2. Go to Step 5, substep 12.
  3. Compare the code in the lab to the code in the autogenerated spinup-destroy.yml file

Expected behavior The code in both places should match (ideally), or at the very least, the user should be told to replace the code with the code in the file.

Desktop (please complete the following information):