search

githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure
https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

Automating changing of AZURE_APP_NAME #7

Closed hectorsector closed 4 years ago

hectorsector commented 4 years ago

Reported by @mjcastner:

In Step 5, the user needs to manually update their username for the AZURE_WEBAPP_NAME variable. Earlier in the process, this had been populated automatically. Is it possible for the behavior to be consistent?

hectorsector commented 4 years ago

Because this step is in a pull request, we rely on the files in the template repository (here's the Learning Lab docs on template repos, if it's helpful). It's hard to populate the template repo with data specific to the user at the moment, so that's why we don't populate it automatically. In the response itself, we can easily use variables like the learner's username, so it's included there.

The only alternative I see is using a pull request that has less content pre-populated, and asking the learner to add the rest. Specifically, we could populate only these highlighted lines and ask the learner to populate the rest by copying-and-pasting. This does mean that they're doing two things, renaming + adding content (like they did in step one). What do you think @mjcastner?

hectorsector commented 4 years ago

One thing I forgot to mention is that although we cannot programmatically include the proper value of AZURE_WEBAPP_NAME in the template repo, we do validate whether the line has been properly changed:

https://github.com/githubtraining/continuous-delivery-azure/blob/a118954f95863515cec4d949e4d65acc0cc23851/config.yml#L171-L179

hectorsector commented 4 years ago

I think this is taken care of, we do programmatically fill it in for the learner and allow them to copy-paste.