search

githubtraining / continuous-delivery-azure

Course repository for the Learning Lab course GitHub Actions: Continuous Delivery with Azure
https://lab.github.com/githubtraining/github-actions:-continuous-delivery-with-azure/
Creative Commons Attribution 4.0 International
0 stars 2 forks source link

Hardcoded variable #8

Closed hectorsector closed 4 years ago

hectorsector commented 4 years ago

Reported by @mjcastner:

Step 9 has "hectorsector" hardcoded into the expected results for AZURE variables. This will cause a copy / paste commit to fail in the CI/CD run and prevent merge.

hectorsector commented 4 years ago

Yikes, good catch! This is in responses/10_deploy-prod.md. It should use variable names like we do in responses/02_conditional.md, for example. I'll get a PR opened up to fix this.

Here's some docs on variable names in case it helps to understand how this works!