search

githubtraining / using-github-actions-for-ci

Course repository for "GitHub Actions: Continuous Integration"
https://lab.github.com/githubtraining/github-actions:-continuous-integration
Creative Commons Attribution 4.0 International
3 stars 16 forks source link

In Step 11, suggested change is on wrong line of file #56

Open bgottula opened 3 years ago

bgottula commented 3 years ago

Bug Report

Current behavior In Step 11, a code change is suggested by the bot. There is an associated "suggested change" in the pull request, but it is not applied to the correct location in the file.

Reproduction Steps to reproduce the behavior in the course:

  1. Go through the coarse until reaching Step 11, hopping over the other bugs in the coarse as needed
  2. Look at the "suggested change" provided in Step 11

Expected behavior The suggested change should match the change described by the bot.

Possible solution Seems like the coarse itself needs some better CI, since there are multiple bugs in it currently. :sweat_smile:

Additional context Here's what the bot asks for in the instructions: image

Here's what the suggested change is. Note that it is being applied in the test section rather than the build section. image