search

gitify-app / gitify

GitHub notifications on your menu bar. Available on macOS, Windows & Linux.
https://www.gitify.io
MIT License
4.38k stars 256 forks source link

Remove @electron/remote #650

Open bmulholland opened 9 months ago

bmulholland commented 9 months ago

Usage of @electron/remote is discouraged

We can replace it with inter-process communication fairly easily, just need to do it piece by piece.

setchy commented 3 months ago

@bmulholland - would you mind confirming that this can be closed. I did a search and couldn't find any references to remote from the electron package directly. All seem to have been migrated to @electron/remote (thank you kindly)

bmulholland commented 3 months ago

All seem to have been migrated to @electron/remote

That's the package that is discouraged and shouldn't be used. From the linked article, about @electron/remote itself:

⚠️ Warning! This module has many subtle pitfalls. There is almost always a better way to accomplish your task than using this module. For example, ipcRenderer.invoke can serve many common use cases.

setchy commented 3 months ago

Oops! I misread it. I focused on this comment but missed the warning. Thanks for the correction 🙇

@electron/remote is a replacement for the built-in remote module in Electron, which is deprecated and will eventually be removed.