gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
13.01k stars 1.24k forks source link

extensions: Don't override sync setting for an extension if installed before opening a repository with that extension on Gitpod workspace conig's vscode.extensions #7363

Closed ajhalili2006 closed 2 years ago

ajhalili2006 commented 2 years ago

Is your feature request related to a problem? Please describe

When I add some of the extensions I use to .gitpod.yml on one repo and then creates a fresh workspace on another repo, some of these extensions are not installed due to Sync This Extension being unmarked when opening a repository with that extension on their configuration.

Describe the behaviour you'd like

If a user has that extension installed BEFORE opening that repository with some of user's extensions on the vsocde.extensions list in the configuration YAML file, respect Sync This Extension setting for these extensions.

Describe alternatives you've considered

You may need to manually tick that on every extension that got ignored by Gitpod Web due to extensions being mentioned on the config file, which is sometimes a painful chore to do.

Additional context

N/A

akosyakov commented 2 years ago

Could you clarify steps to reproduce:

ajhalili2006 commented 2 years ago

I tried installing Golang extension on an existing workspace, leaving Sync This Extension option checked.

photo_2021-12-29_12-47-08

Then created a fresh workspace using github:gitpod-io/gitpod where that extension is added to the Gitpod config, and confirmed that option is unchecked.

photo_2021-12-29_12-47-03

But when I created another fresh workspace without that extension in the config, it has Sync This Extension option checked.

photo_2021-12-29_13-24-47

Maybe this is probably an accidental bug on the UI/Setting Sync backend/Gitpod config parser?

akosyakov commented 2 years ago

But when I created another fresh workspace without that extension in the config, it has Sync This Extension option checked.

It looks expected: If you install an extension like sync then it will be installed like sync in all your workspaces except which have configured it explicitly in .gitpod.yml

akosyakov commented 2 years ago

Can be closed? I am still uncertain what is the bug. @jeanp413 could you have a look as well, not fixing, but help to understand the issue

jeanp413 commented 2 years ago

Yeah, I'll close it as it's the intended behavior as you explained.

If you install an extension like sync then it will be installed like sync in all your workspaces except which have configured it explicitly in .gitpod.yml