Open gengjiawen opened 2 years ago
Given that the layers can be merged in any order we cannot add a chunk to fix this. I am wondering if this is somethings that should be fixed in the image. @gengjiawen can you help me with the path/env that you expected vs what you saw?
All the tools and resources that we provide in the image should be useable by gitpod
user. For root we need to find out a better strategy.
The comment has the issue link: # share env see https://github.com/gitpod-io/workspace-images/issues/472
I saw that issue. That is the reason I am wondering if we can have a strategy to fix this, we can;t simply add it to the full combination due to unordered merge of images. There is a hack to do this, by building a partial image combo and then referencing this as base for the full image
Hey @princerachit , I am going to be busy with backup resiliency work, so cannot look at this issue right now. @Furisto would you have some time to take this?
Currently still working on something else, so if anyone else is able to pick it up, go ahead.
@utam0k given the recent fix you did for path, is this still an issue?
@kylos101 This is different from the $PATH
problem I solved before. This is the problem with $PATH
not being reflected for non-gitpod users.
@kylos101 Is there any hook and final steps for full Dockerfile ? In my understanding this is a dazzle flaw ?
https://github.com/gitpod-io/workspace-images/blob/d43c719bb2ff7b6849c0456fe21e3ca06c20168f/legacy/full/Dockerfile?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L299
cc @princerachit @kylos101