giuliov / hugo-vsts-extension

Generate a site using Hugo, a Fast and Flexible Website Generator, running in Visual Studio Team Services or Team Foundation Server.
MIT License
24 stars 15 forks source link

Extension does not work with Hugo versions above v0.88.1 #19

Open PalmEmanuel opened 2 years ago

PalmEmanuel commented 2 years ago

The extension finds the Windows 64 release by looking at if the name of the asset matches '*Windows*64*'. https://github.com/giuliov/hugo-vsts-extension/blob/f4512a1623903b9cc41811961221c040319b561e/hugo-task/Select-HugoVersion.ps1#L26

Up until version 0.88.1 this only matched on hugo_<version>_Windows-64bit.zip but after version 0.89 it also matches on a new asset called hugo_<version>_Windows-ARM64.zip.

The logic for finding the download URL for the version should change to handle this new asset in the Hugo releases.

gaelcolas commented 2 years ago

Yep, we hit the same problem here: https://dev.azure.com/dsccommunity/dsccommunity.org/_build/results?buildId=5252&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=2d65d1e2-3936-5248-963b-4ff25d1b8072

Updating the line with this should do the trick: $win64hugo = $release.assets | where { $_.name -like '*Windows-64*' } or we could go for a regex match instead: $win64hugo = $release.assets | where { $_.name -match 'Windows\-64.*' }

giuliov commented 2 years ago

Solved in version 2.0 and above