search

gix / foo_scrobble

foobar2000 component for last.fm scrobbling
MIT License
428 stars 12 forks source link

"Now playing" notifications are displayed even if scrobbling is off #20

Open death-owl opened 4 years ago

death-owl commented 4 years ago

Thank you for this component. :) I posted the following report on the Hydrogenaudio forum thread a couple of weeks ago, but the issue reports section here might be a more appropriate place for it, so...

If you have "Send now playing notifications" ticked on, it displays the "Scrobbling now" track on your Last.fm profile even if you have scrobbling turned off. Expected behavior would be to display the "now playing" track only if scrobbling is also turned on. I can't think of any instance when a user would prefer to send "now playing" notifications about tracks they are not scrobbling. Because of this, I currently have the "now playing" option permanently off... until it gets fixed, I hope. :)

gix commented 4 years ago

If I remember correctly this was a deliberate decision (also why both checkboxes are on the same level, and disabling scrobbling does not disable the other checkbox) so that both may be used independently. I don't understand your last sentence though. Presumably at some point you disable scrobbling. What's stopping you from unchecking the other option at the same time?

death-owl commented 4 years ago

Hello, thanks for the reply! :)

As for "What's stopping you from unchecking the other option at the same time?" - just inconvenience! :) Clicking "Scrobble tracks" on/off is two clicks (first click "Playback" in the main menu, then "Scrobble tracks" in that menu). Clicking "Send now playing notifications" would be several more clicks on top of that (ctrl-p for the preferences menu, then clicking "Last.fm scrobbling" in that menu, then "Send now playing notifications" in that menu). Too much of a hassle to do every time.

I usually turn off scrobbling if I'm listening to either audiobooks or music that I haven't properly tagged yet. Then I turn scrobbling back on each time I switch to music that I've properly tagged and sorted. I often alternate between listening to an audiobook and listening to music, so often I turn scrobbling on/off several times a day.

Up to last spring I used Last.fm's own separate scrobbling app, but it has its own set of bugs by now, so I gave it up and switched to your foo_scrobble instead - and on the whole, your component is clearly better. Switching scrobbling on or off was slightly more convenient in the old app though, because you could see at a glance whether it was on or off (the app icon in the Windows notification area was grayed out if scrobbling was off). In the old app, the "now playing" thing also worked intuitively - the "now playing" notifications were automatically turned on or off based on whether scrobbling was on or off).

But if separating the now playing option from the scrobbling option was a deliberate choice as you say, how about adding an option that lets the user choose whether now playing is dependent on scrobbling or not? That way we could have it both ways. :)

Keiyuu commented 1 year ago

And plans to implement this? I'm currently trying to switch from the official legacy scrobbler and this is still one of those things I find cumbersome. As death-owl pointed out, it's inconvenient to go through foobar's settings menu every time you want to enable or disable scrobbling. I would prefer "now playing" to work in tandem with scrobbling on/off.