search

gix / foo_scrobble

foobar2000 component for last.fm scrobbling
MIT License
428 stars 12 forks source link

foobar crashes when internet connection is interrupted #30

Open darekkay opened 3 years ago

darekkay commented 3 years ago

I've been having issues with my internet provider lately. Foobar2000 is crashing whenever my internet connection is interrupted and foo_scrobble is responsible for that. From the crash report:

Opening track for playback: "song.mp3" foo_scrobble: Submitting track foo_scrobble: Scrobbling failed (WinHttpSendRequest: 12007: Der Servername oder die Serveradresse konnte nicht verarbeitet werden. [error code: 12007, Der Servername oder die Serveradresse konnte nicht verarbeitet werden.])

Unfortunately the notification is in German. But it basically says that the "server name or server address could not be processed".

I remember that foo_scrobble caches the scrobbles when the internet connection is not available. But I guess the code has issues with the connection breaking in the middle of the execution. It's also possible that foo_scrobble (or Foobar2000) only checks for an active LAN/WLAN connection, but not whether there it is connected to the internet.

Steps to reproduce would be to start Foobar2000 with foo_scrobble active and then disconnect the internet connection at router level. After a few minutes, Foobar2000 will crash.

gix commented 3 years ago

I can't reproduce this, simulating various disturbances in the network connection. What makes you sure it's related to foo_scrobble? Is it the only third-party component you are using? foobar2000 collects crash info in %AppData%\Roaming\foobar2000\crash reports, could you look for clues there? A crash dump with foo_scrobble at the top of the stack analysis would obviously be the most helpful.

darekkay commented 3 years ago

Hey @gix ,

the message above comes from the crash report. See the full report at the end of this post. I'm fairly sure it's foo_scrobble because of:

Crash location: Module: foo_scrobble

I've just tried to reproduce it, but I was unable to. When my internet provider has issues, it looks like a DNS issue. Active connections keep running, but new connections don't work. This would also explain the error message ("couldn't resolve address").

Maybe a try-catch around the code that does the actual HTTP request might solve the problem. I guess it's rather an edge case that not many people might experience, so feel free to close this issue (or leave it open) if it's too much effort.

Illegal operation:
Code: 80000003h, flags: 00000000h, address: 791F3481h
Additional parameters: 00000000h

Call path not available.

Code bytes (791F3481h):
791F3441h:  00 59 8B E5 5D C3 CC CC CC CC CC CC CC CC CC 55
791F3451h:  8B EC 6A FF 68 E0 B8 26 79 64 A1 00 00 00 00 50
791F3461h:  56 A1 D4 90 29 79 33 C5 50 8D 45 F4 64 A3 00 00
791F3471h:  00 00 8B F1 8B 06 85 C0 75 0D FF 15 68 92 27 79
791F3481h:  CC FF 15 60 92 27 79 8B 46 10 85 C0 74 41 8B 4E
791F3491h:  18 2B C8 83 E1 FC 81 F9 00 10 00 00 72 12 8B 50
791F34A1h:  FC 83 C1 23 2B C2 83 C0 FC 83 F8 1F 77 3E 8B C2
791F34B1h:  51 50 E8 B4 DE 06 00 C7 46 10 00 00 00 00 83 C4

Stack (072EF46Ch):
072EF44Ch:  01580000 00000000 072EF474 776CD796
072EF45Ch:  00000000 00000000 00000000 791F3481
072EF46Ch:  15DF7229 0B483CE8 072EF49C 7926B8E0
072EF47Ch:  FFFFFFFF 072EF4A8 791F4321 15DF7201
072EF48Ch:  050F9B88 050F9AB0 0B4E4710 050F9AB0
072EF49Ch:  072EF4C0 7926BB50 FFFFFFFF 072EF4CC
072EF4ACh:  791F6EBA 15DF7265 050F9AA0 FFFFFFFF
072EF4BCh:  050F9AB0 072EF524 7926BFE0 00000000
072EF4CCh:  072EF530 791F840A 00000000 791F4972
072EF4DCh:  15DF7399 059640F8 00000000 00000000
072EF4ECh:  050F9AB0 050F9AA0 072EF51C 791F27A0
072EF4FCh:  776B1435 072EF52C 776E91FF 0BA58528
072EF50Ch:  00000006 776E91FF 7C508050 00000000
072EF51Ch:  15DF7399 791F0000 072EF550 7926BC85
072EF52Ch:  00000000 072EF55C 791F8DDE 051BE508
072EF53Ch:  0B483A18 7C508050 791F3202 15DF73F5
072EF54Ch:  0B4661F8 072EF570 7926B93D 00000000
072EF55Ch:  072EF57C 791F27D8 0B483A18 15DF73D5
072EF56Ch:  791F27A0 072EF590 7926B7CD 00000000
072EF57Ch:  072EF59C 7C5080A1 0B4661F8 BF8F719F

Registers:
EAX: 00000000, EBX: FFFFFFFF, ECX: 0B483CF4, EDX: 01580000
ESI: 0B483CF4, EDI: 050F9AB0, EBP: 072EF480, ESP: 072EF46C

Crash location:
Module: foo_scrobble
Offset: 3481h

Loaded modules:
foobar2000                       loaded at 00EF0000h - 01150000h
ntdll                            loaded at 77680000h - 7781A000h
KERNEL32                         loaded at 74F50000h - 75030000h
KERNELBASE                       loaded at 75080000h - 7527F000h
SHLWAPI                          loaded at 756E0000h - 75724000h
msvcrt                           loaded at 75960000h - 75A1F000h
COMCTL32                         loaded at 74780000h - 7498F000h
combase                          loaded at 760A0000h - 76316000h
WINMM                            loaded at 73B20000h - 73B44000h
ucrtbase                         loaded at 755C0000h - 756E0000h
GDI32                            loaded at 75730000h - 75751000h
win32u                           loaded at 77650000h - 77667000h
RPCRT4                           loaded at 76BD0000h - 76C8B000h
WINMMBASE                        loaded at 73940000h - 73963000h
gdi32full                        loaded at 75800000h - 7595D000h
SspiCli                          loaded at 74E50000h - 74E75000h
cfgmgr32                         loaded at 75280000h - 752BB000h
msvcp_win                        loaded at 76970000h - 769EC000h
CRYPTBASE                        loaded at 74E40000h - 74E4A000h
bcryptPrimitives                 loaded at 75560000h - 755C0000h
USER32                           loaded at 752C0000h - 75458000h
sechost                          loaded at 768F0000h - 76966000h
ADVAPI32                         loaded at 754E0000h - 75559000h
SHELL32                          loaded at 76FC0000h - 7753B000h
UxTheme                          loaded at 74680000h - 746FA000h
shcore                           loaded at 76D90000h - 76E13000h
windows.storage                  loaded at 76320000h - 768DF000h
profapi                          loaded at 769F0000h - 76A0B000h
powrprof                         loaded at 76D40000h - 76D83000h
UMPDC                            loaded at 75760000h - 7576D000h
kernel.appcore                   loaded at 768E0000h - 768EF000h
cryptsp                          loaded at 77550000h - 77563000h
ole32                            loaded at 75A20000h - 75B17000h
OLEAUT32                         loaded at 76A10000h - 76AA2000h
CRYPT32                          loaded at 75FA0000h - 7609B000h
MSASN1                           loaded at 74E80000h - 74E8E000h
MSVCP140                         loaded at 7C4F0000h - 7C560000h
MSIMG32                          loaded at 74770000h - 74776000h
gdiplus                          loaded at 74CA0000h - 74E0A000h
OLEACC                           loaded at 74990000h - 749E3000h
WINHTTP                          loaded at 72DB0000h - 72E6D000h
Secur32                          loaded at 739B0000h - 739BA000h
VCRUNTIME140                     loaded at 7C560000h - 7C574000h
zlib1                            loaded at 63080000h - 63099000h
shared                           loaded at 7C580000h - 7C5A1000h
imagehlp                         loaded at 76E30000h - 76E4B000h
COMDLG32                         loaded at 76C90000h - 76D40000h
dbghelp                          loaded at 735C0000h - 7374F000h
dbgcore                          loaded at 73590000h - 735B4000h
IMM32                            loaded at 75F70000h - 75F95000h
MSCTF                            loaded at 76AC0000h - 76BC3000h
foo_plorg                        loaded at 793A0000h - 793CD000h
MSVCR100                         loaded at 79440000h - 794FF000h
MSVCP100                         loaded at 793D0000h - 79439000h
foo_lyricsource                  loaded at 788D0000h - 78907000h
libxml2                          loaded at 10000000h - 100F5000h
WSOCK32                          loaded at 6C1E0000h - 6C1E8000h
WS2_32                           loaded at 775F0000h - 7764E000h
iconv                            loaded at 04A50000h - 04B29000h
foo_converter                    loaded at 78AF0000h - 78B7E000h
foo_cdda                         loaded at 78B80000h - 78BB9000h
foo_uie_lyrics3                  loaded at 05B40000h - 05BFB000h
WININET                          loaded at 740E0000h - 7453B000h
foo_fileops                      loaded at 79350000h - 79392000h
foo_freedb2                      loaded at 78980000h - 789B1000h
foo_lyricsgrabber2               loaded at 789D0000h - 78A8C000h
WLDAP32                          loaded at 74E90000h - 74EE6000h
python25                         loaded at 1E000000h - 1E208000h
MSVCR71                          loaded at 7C340000h - 7C396000h
foo_dsp_effect                   loaded at 05EC0000h - 05F05000h
foo_scrobble                     loaded at 791F0000h - 792BB000h
bcrypt                           loaded at 77570000h - 77589000h
VERSION                          loaded at 73910000h - 73918000h
CONCRT140                        loaded at 792C0000h - 792FD000h
DPAPI                            loaded at 6CD70000h - 6CD78000h
foo_ui_std                       loaded at 7C710000h - 7C821000h
foo_albumlist                    loaded at 79300000h - 79349000h
foo_rgscan                       loaded at 7C830000h - 7C879000h
foo_unpack                       loaded at 78930000h - 78973000h
foo_input_monkey                 loaded at 05F40000h - 05F99000h
foo_dsp_std                      loaded at 78AC0000h - 78AED000h
foo_quicktag                     loaded at 78890000h - 788C4000h
foo_input_std                    loaded at 78BC0000h - 78D1A000h
MSACM32                          loaded at 532F0000h - 53309000h
avutil-fb2k-56                   loaded at 78F40000h - 791E5000h
avcodec-fb2k-58                  loaded at 78D20000h - 78F37000h
foo_dsp_eq                       loaded at 78A90000h - 78AB7000h
atlthunk                         loaded at 6F480000h - 6F48D000h
clbcatq                          loaded at 75460000h - 754E0000h
dataexchange                     loaded at 6E440000h - 6E471000h
dcomp                            loaded at 6E240000h - 6E3AA000h
d3d11                            loaded at 73000000h - 731DE000h
dxgi                             loaded at 73A20000h - 73AE1000h
dxcore                           loaded at 73920000h - 73939000h
twinapi.appcore                  loaded at 6F290000h - 6F473000h
RMCLIENT                         loaded at 6F270000h - 6F28F000h
sud                              loaded at 79680000h - 796A7000h
PROPSYS                          loaded at 74A50000h - 74B16000h
ADVPACK                          loaded at 79820000h - 7984E000h
DUI70                            loaded at 796B0000h - 79817000h
SETUPAPI                         loaded at 75B20000h - 75F69000h
_socket                          loaded at 09C80000h - 09C8D000h
explorerframe                    loaded at 77DE0000h - 77F63000h
TextInputFramework               loaded at 6EB70000h - 6EBF2000h
CoreUIComponents                 loaded at 6E880000h - 6EADE000h
CoreMessaging                    loaded at 6EAE0000h - 6EB69000h
ntmarta                          loaded at 73760000h - 73789000h
wintypes                         loaded at 6E7A0000h - 6E877000h
iertutil                         loaded at 729D0000h - 72BFA000h
avrt                             loaded at 53330000h - 53338000h
MMDevApi                         loaded at 6E6E0000h - 6E742000h
DEVOBJ                           loaded at 6E6B0000h - 6E6D3000h
AUDIOSES                         loaded at 62A00000h - 62B1F000h
resourcepolicyclient             loaded at 605B0000h - 605BF000h
WindowsCodecs                    loaded at 62890000h - 629F9000h
mswsock                          loaded at 73850000h - 738A2000h
IPHLPAPI                         loaded at 74A10000h - 74A42000h
WINNSI                           loaded at 6CDE0000h - 6CDE8000h
NSI                              loaded at 76E20000h - 76E27000h
dhcpcsvc6                        loaded at 6F160000h - 6F173000h
ondemandconnroutehelper          loaded at 6CDF0000h - 6CE02000h
dhcpcsvc                         loaded at 73970000h - 73985000h
webio                            loaded at 6C450000h - 6C4C7000h
DNSAPI                           loaded at 6F710000h - 6F7A3000h
rasadhlp                         loaded at 6D430000h - 6D438000h
urlmon                           loaded at 72C00000h - 72DAC000h
fwpuclnt                         loaded at 6D1F0000h - 6D241000h
schannel                         loaded at 6C3D0000h - 6C446000h
mskeyprotect                     loaded at 6CB20000h - 6CB30000h
ncrypt                           loaded at 739E0000h - 73A01000h
NTASN1                           loaded at 738B0000h - 738D8000h
ncryptsslp                       loaded at 6C3B0000h - 6C3CF000h
cryptnet                         loaded at 6C380000h - 6C3A6000h
rsaenh                           loaded at 73800000h - 7382F000h
gpapi                            loaded at 66590000h - 665AE000h

Stack dump analysis:
Address: 7926B8E0h (foo_scrobble+7B8E0h), symbol: "foobar2000_get_interface" (+41D60h)
Address: 791F4321h (foo_scrobble+4321h)
Address: 7926BB50h (foo_scrobble+7BB50h), symbol: "foobar2000_get_interface" (+41FD0h)
Address: 791F6EBAh (foo_scrobble+6EBAh)
Address: 7926BFE0h (foo_scrobble+7BFE0h), symbol: "foobar2000_get_interface" (+42460h)
Address: 791F840Ah (foo_scrobble+840Ah)
Address: 791F4972h (foo_scrobble+4972h)
Address: 791F27A0h (foo_scrobble+27A0h)
Address: 776B1435h (ntdll+31435h), symbol: "TpReleaseWork" (+105h)
Address: 776E91FFh (ntdll+691FFh), symbol: "RtlPcToFileHeader" (+1Fh)
Address: 776E91FFh (ntdll+691FFh), symbol: "RtlPcToFileHeader" (+1Fh)
Address: 7C508050h (MSVCP140+18050h), symbol: "Concurrency::details::_Schedule_chore" (+70h)
Address: 791F0000h (foo_scrobble+0h)
Address: 7926BC85h (foo_scrobble+7BC85h), symbol: "foobar2000_get_interface" (+42105h)
Address: 791F8DDEh (foo_scrobble+8DDEh)
Address: 7C508050h (MSVCP140+18050h), symbol: "Concurrency::details::_Schedule_chore" (+70h)
Address: 791F3202h (foo_scrobble+3202h)
Address: 7926B93Dh (foo_scrobble+7B93Dh), symbol: "foobar2000_get_interface" (+41DBDh)
Address: 791F27D8h (foo_scrobble+27D8h)
Address: 791F27A0h (foo_scrobble+27A0h)
Address: 7926B7CDh (foo_scrobble+7B7CDh), symbol: "foobar2000_get_interface" (+41C4Dh)
Address: 7C5080A1h (MSVCP140+180A1h), symbol: "Concurrency::details::_Schedule_chore" (+C1h)
Address: 7C52FCD4h (MSVCP140+3FCD4h), symbol: "std::basic_ostream<char,std::char_traits<char> >::write" (+1E44h)
Address: 776B9984h (ntdll+39984h), symbol: "TpCallbackIndependent" (+2954h)
Address: 776B9840h (ntdll+39840h), symbol: "TpCallbackIndependent" (+2810h)
Address: 776B8418h (ntdll+38418h), symbol: "TpCallbackIndependent" (+13E8h)
Address: 776B868Ch (ntdll+3868Ch), symbol: "TpCallbackIndependent" (+165Ch)
Address: 776B7F60h (ntdll+37F60h), symbol: "TpCallbackIndependent" (+F30h)
Address: 776B7F60h (ntdll+37F60h), symbol: "TpCallbackIndependent" (+F30h)
Address: 7C508050h (MSVCP140+18050h), symbol: "Concurrency::details::_Schedule_chore" (+70h)
Address: 791F0000h (foo_scrobble+0h)
Address: 776FB130h (ntdll+7B130h), symbol: "wcstombs" (+70h)
Address: 74F66359h (KERNEL32+16359h), symbol: "BaseThreadInitThunk" (+19h)
Address: 74F66340h (KERNEL32+16340h), symbol: "BaseThreadInitThunk" (+0h)
Address: 776E8944h (ntdll+68944h), symbol: "RtlGetAppContainerNamedObjectPath" (+E4h)
Address: 776FB130h (ntdll+7B130h), symbol: "wcstombs" (+70h)
Address: 776E8914h (ntdll+68914h), symbol: "RtlGetAppContainerNamedObjectPath" (+B4h)
Address: 7770A0B3h (ntdll+8A0B3h), symbol: "RtlCaptureContext" (+D3h)
Address: 776B7F60h (ntdll+37F60h), symbol: "TpCallbackIndependent" (+F30h)

Environment:
App: foobar2000 v1.6.2
UI: Default User Interface 1.6.2

Components:
Core (2020-10-22 15:45:46 UTC)
    foobar2000 core 1.6.2
foo_albumlist.dll (2020-10-22 15:45:04 UTC)
    Album List 4.7
foo_cdda.dll (2020-10-22 15:45:02 UTC)
    CD Audio Decoder 1.6.2
foo_converter.dll (2020-10-22 15:45:08 UTC)
    Converter 1.6.2
foo_dsp_effect.dll (2016-03-11 16:14:03 UTC)
    Effect DSP 0.16
foo_dsp_eq.dll (2020-10-22 15:44:58 UTC)
    Equalizer 1.2.2
foo_dsp_std.dll (2020-10-22 15:44:58 UTC)
    Standard DSP Array 1.6.2
foo_fileops.dll (2020-10-22 15:45:04 UTC)
    File Operations 1.6.2
foo_freedb2.dll (2020-10-22 15:45:02 UTC)
    Online Tagger 0.8
foo_input_monkey.dll (2020-10-12 11:34:29 UTC)
    Monkey's Audio Decoder 2.3.1
foo_input_std.dll (2020-10-22 15:45:32 UTC)
    FFmpeg Decoders 4.3.1
    Standard Input Array 1.6.2
foo_lyricsgrabber2.dll (2012-12-26 19:03:40 UTC)
    Lyrics Grabber 2 0.5.5.2 beta
foo_lyricsource.dll (2016-03-11 16:08:20 UTC)
    Custom lyrics source 0.1
foo_plorg.dll (2015-10-13 07:24:47 UTC)
    Playlist Organizer 2.6
foo_quicktag.dll (2010-09-01 08:15:08 UTC)
    Quick Tagger 1.0.3
foo_rgscan.dll (2020-10-22 15:45:08 UTC)
    ReplayGain Scanner 1.6.2
foo_scrobble.dll (2020-11-22 18:30:58 UTC)
    Scrobble 1.4.0.20572
foo_ui_std.dll (2020-10-22 15:45:14 UTC)
    Default User Interface 1.6.2
foo_uie_lyrics3.dll (2016-08-04 17:37:04 UTC)
    Lyric Show Panel 3 0.5
foo_unpack.dll (2020-10-22 15:45:04 UTC)
    ZIP/GZIP/RAR/7-Zip Reader 1.6.2

Recent events:
Opening track for playback: "D:\song1.mp3"
foo_scrobble: Submitting track
Opening track for playback: "D:\song2.mp3"
foo_scrobble: Submitting track
Opening track for playback: "D:\song3.mp3"
foo_scrobble: Submitting track
foo_scrobble: Submitting track
foo_scrobble: Scrobbling failed (WinHttpSendRequest: 12007: Der Servername oder die Serveradresse konnte nicht verarbeitet werden. [error code: 12007, Der Servername oder die Serveradresse konnte nicht verarbeitet werden.])
foo_scrobble: Submitting track
foo_scrobble: Scrobbling failed (WinHttpSendRequest: 12007: Der Servername oder die Serveradresse konnte nicht verarbeitet werden. [error code: 12007, Der Servername oder die Serveradresse konnte nicht verarbeitet werden.])
foo_scrobble: Submitting track
foo_scrobble: Scrobbling failed (WinHttpSendRequest: 12007: Der Servername oder die Serveradresse konnte nicht verarbeitet werden. [error code: 12007, Der Servername oder die Serveradresse konnte nicht verarbeitet werden.])
foo_scrobble: Submitting track
foo_scrobble: Scrobbling failed (WinHttpSendRequest: 12007: Der Servername oder die Serveradresse konnte nicht verarbeitet werden. [error code: 12007, Der Servername oder die Serveradresse konnte nicht verarbeitet werden.])
Opening track for playback: "song.mp3"
foo_scrobble: Queuing scrobble (Sleeping)
foo_scrobble: Submitting 2 of 2 cached tracks

Machine specifications:
OS: Windows 10.0.18363 x64
CPU: AMD Ryzen 7 1700 Eight-Core Processor, features: MMX SSE SSE2 SSE3 SSE4.1 SSE4.2
CPU threads: 16
Audio: Lautsprecher (Steam Streaming Speakers); Lautsprecher (Steam Streaming Microphone); Lautsprecher (Realtek High Definition Audio); Realtek Digital Output (Realtek High Definition Audio)
gix commented 3 years ago

Maybe a try-catch around the code that does the actual HTTP request might solve the problem.

Well, that should already be the case. The stack trace shows an unhandled exception though. No idea where that is coming from. There may be more info in the dump file.

darekkay commented 3 years ago

Here's the dump file:

failure_00000003.zip