gix / foo_scrobble

foobar2000 component for last.fm scrobbling
MIT License
428 stars 12 forks source link

Certain tracks aren't scrobbled #33

Open flickur opened 3 years ago

flickur commented 3 years ago

Some tracks just aren't being scrobbled. One example is an album that I tagged using mp3tag.

image image

gix commented 3 years ago

Does the console in foobar (View -> Console) say anything when one of those songs is played? Does it say foo_scrobble: Submitting track, does it display some error? And just to be sure, in the foo_scrobble settings, the "Skip format" field is empty?

flickur commented 3 years ago

here's full console,

Components loaded in: 0:00.026117 Configuration read in: 0:00.002377 foobar2000 v1.6.2 [standard] Folder watching failure: The system cannot find the path specified.
User Interface initialized in: 0:00.084473 FFmpeg version: 4.3.1 Audioscrobbler: Couldn't read the Last.fm exe path from the registry. Audioscrobbler: Loaded Startup time : 0:00.172704 Opening track for playback: "D:\music\trääns, house ym\Daniel Kandi\0529. Daniel Kandi - Child (Original Mix).mp3" Automatic resampling: using Resampler (dBpoweramp/SSRC), Resampler (PPHS) Device: SPDIF Interface (NuForce µDAC 2) Mix format: 48000 Hz / 32-bit float / 2 channels (0x3) Sending stream: 48000 Hz / 32-bit float / 2 channels (0x3)

image

gix commented 3 years ago

And what does the log say after playing the song? There should be either foo_scrobble: Submitting track or an error message. Are these missing?

flickur commented 3 years ago

oh you meant after the songs has played, my bad.

Components loaded in: 0:00.884004
Configuration read in: 0:00.003177
foobar2000 v1.6.2 [standard]
Folder watching failure: The system cannot find the path specified.  
User Interface initialized in: 0:00.092358
FFmpeg version: 4.3.1
Audioscrobbler: Couldn't read the Last.fm exe path from the registry.
Audioscrobbler: Loaded
Startup time : 0:01.078803
Opening track for playback: "D:\music\trääns, house ym\VA-Trance.Top.1000-FF 1337\0140. ATB - Behind (Original Mix).mp3"
Automatic resampling: using Resampler (dBpoweramp/SSRC), Resampler (PPHS)
Device: SAMSUNG (NVIDIA High Definition Audio)
Mix format: 48000 Hz / 32-bit float / 2 channels (0x3)
Sending stream: 48000 Hz / 32-bit float / 2 channels (0x3)
Opening track for playback: "D:\music\trääns, house ym\VA-Trance.Top.1000-FF 1337\0181. Rank 1 - Symfo (Original Mix).mp3"
foo_scrobble: Submitting track

Also, so far I've seen this only happening with this one album but i'm not able to figure out what's different with these files compared to all the other songs that work fine.

flickur commented 3 years ago

So I changed the album artist, which shouldn't have any effect at all for scrobbling, and it started working. Now i'm wondering if this is a last.fm issue and not a foo_scrobble issue.

edit: yeah it's definitely a last.fm issue, just tested. Anything that has "VA" as album artist won't scrobble. Super weird.

bassstorm commented 2 years ago

@gix first of all, big fat thank you for this plugin! I thought API 2.0 would never appear in fb2k :)

I got exactly the same issue with "VA" album artist. Adjusted mappings to [$ifequal(%album artist%,VA,Various Artists,%album artist%)], and it obviously works nice. But maybe it makes sense to add a warning to the console on those cases when Last.fm rejects a scrobble for some reason?

gix commented 2 years ago

last.fm's response for those is:

<lfm status="ok">
  <scrobbles accepted="0" ignored="1">
    <scrobble>
      <track corrected="0">...</track>
      <artist corrected="0">...</artist>
      <album corrected="0">...</album>
      <albumArtist corrected="0">VA</albumArtist>
      <timestamp>...</timestamp>
      <ignoredMessage code="1"></ignoredMessage>
    </scrobble>
  </scrobbles>
</lfm>

where ignored code 1 is "Artist was ignored". No idea why VA in particular is not accepted. foo_scrobble could log such tracks to the console.

bassstorm commented 2 years ago

Yes, I don't understand the reason behind as well. Nevertheless, once we have at least a warning in the console, this issue could be treated as resolved I think.

flickur commented 2 years ago

It's blacklisted by last.fm, their mod told me that when I first noticed the issue.

The whole thing is pretty pointless since last.fm's album artist tags are a complete mess anyway and all they're accomplishing is disabling people's scrobbles without any notice or warning.

daytimetv commented 1 year ago

I too didn't know about existence of this component and used foo_audioscrobbler until recently, thanks for developing this. Also ran into the issue of tracks with "VA" album artist not scrobbling.

[$ifequal(%album artist%,VA,Various Artists,%album artist%)]

@bassstorm this doesn't work properly since ifequal compares integer values: https://wiki.hydrogenaud.io/index.php?title=Foobar2000:Title_Formatting_Reference#.24ifequal.28int1.2Cint2.2Cthen.2Celse.29 , seems to simply submit artist instead of album artist.

Spent a couple of hours breaking my brain, testing different stuff and ended up with this mapping for album artist: $ifequal($stricmp([%album artist%],VA),1,Various Artists,[%album artist%]) still pretty scuffed, but seems to work correctly for all cases so far for me (album artist being VA, Various Artists, empty or whatever).

bassstorm commented 1 year ago

@daytimetv glad at least to give you a starting point :) Not sure why, but for me it works flawlessly. You also switched over fb2k 2.0 release?