PM as a guest shows "random" users in a dropdown

gizmore / gwf3

Gizmore Website Framework

39 stars 23 forks source link

PM as a guest shows "random" users in a dropdown #99

Open livinskull opened 3 years ago

livinskull commented 3 years ago

PM as a guest shows "random" users in a dropdown. (additonally to the users input on the right side?) Should probably changed that to show the same free-form input as the logged-in view. (Showing ALL users is not an option - too many)

Alternatively one could think about including sth like select2 - but it's not used anywhere else, and this is an edge-case feature which isn't even linked.

dloser commented 3 years ago

These are not random, but users that have enabled "Allow Guests to PM me" in the PM settings. So this seems to be very intentional gizzy functionality.

https://github.com/gizmore/gwf3/blob/91a3862/core/module/PM/method/Overview.php#L37 https://github.com/gizmore/gwf3/blob/91a3862/core/module/PM/method/Overview.php#L214

Sending to others should not be allowed: https://github.com/gizmore/gwf3/blob/91a3862/core/module/PM/Module_PM.php#L189

livinskull commented 3 years ago

Interesting. Even though that's unclear to the users :)

Additionally it:

does render 2 username inputs
as far as I can see you can still use the second field and it will overwrite the dropdown? https://github.com/gizmore/gwf3/blob/91a3862/core/module/PM/method/Send.php#L146

EDIT: Nvm the second point, while it allows to go to the send page, it'll throw an error there - a broken error message I might add 2021-04-09_113026