search

gjaldon / ecto_enum

Ecto extension to support enums in models
MIT License
563 stars 131 forks source link

Bump version for ecto dependency requirement to 2.2.x #48

Closed kcurtin closed 7 years ago

kcurtin commented 7 years ago

The mix.lock requires ecto 2.1.x, which prevents upgrading to ecto 2.2.x. I bumped the version requirement and ran the tests and things seem fine.

matthewlehner commented 7 years ago

It might be better to set the version to ~>2.2 as this will allow for any 2.x release of Ecto. Since Ecto follows semver, there won't be any breaking changes on minor version changes, just feature additions.

leifg commented 7 years ago

I agree, we should switch the version to ~> 2.1.

As it seems that ecto doesn't support 1.3 any more we could also consider changing the .travis.yml. And then bump up the version of ecto_enum to 1.1.

kcurtin commented 7 years ago

I updated the dep specification and changed the travis build to run w. elixir 1.4.0 and 1.5.0. I also updated the version to 1.1.0

cc @gjaldon

wfgilman commented 7 years ago

@gjaldon Any chance we can get this PR merged?

ryanwinchester commented 7 years ago

Have you guys got this working in the latest ecto/phoenix versions?

I get

** (ArgumentError) invalid or unknown type MyEnum for field :my_field