search

gjb2048 / moodle-theme_essential

The Essential Moodle Theme
https://gjb2048.github.io/moodle-theme_essential/
GNU General Public License v3.0
91 stars 120 forks source link

Grade report alignment horizontal scroll on small screen size #879

Open mnods opened 5 years ago

mnods commented 5 years ago

using 3.5.1.0 and 3.4.1.2

i recall this being an issue in an earlier version.

on smaller screen size in grader report, (grade/report/grader/index.php) using horiz scroll with a fair number of students, the column that sticks (div with classes "floater sideonly floating") is vertically misaligned, making it very hard to grade properly, especially with a large class.

altering the inline css to top: 88px;

seems to fix it.

seems ok in clean.

mnods commented 5 years ago

i've found with this issue that a page refresh realigns the floater column. haven't tracked down the cause though.

mnods commented 5 years ago

note- misalignment happens at less than 979px

gjb2048 commented 5 years ago

Ok 'altering the inline css to top: 88px;' won't work because that value is generated (and changed) by the underlying JavaScript. The issue is caused by the core JavaScript being written for the specifics of the themes in core Moodle and thus is not adaptable / flexible enough to cope with changes in contributed themes - its written in a constraining way. The solution is to disable that JS (somehow) and use theme specific JS to implement the same functionality or find another solution to the issue of not seeing the table headers when there are a large number of columns. This is not 'trivial' as I think the markup output is difficult to override.

mnods commented 5 years ago

yes gareth, i get that i can't change the inline generated css, just wondered if there's a reasonably simple adjustment that can be made to the css for below 979px that is causing the extra height for that floating column calculation. the height calc looks fixed to me. not easy i can see. weird that a refresh resets it.

gjb2048 commented 5 years ago

I've previously spent 'days' on this! I'll look again when I get a moment. This is not easy!!

mnods commented 5 years ago

given the way it's set up and the difficulty involved, i wonder whether the grade report should really be stripped of theme styles in the same way as the assignment grading page?

gjb2048 commented 5 years ago

Possibly.

gjb2048 commented 5 years ago

This one is difficult, so going to leave for now.