Closed gemguardian closed 5 years ago
Are you running 3.5.1.4 Gem?
How can I replicate this?
This is Boost:
and I don't see what the problem is!
Hi Gareth,
Archhhh damm it! wrong picture!
Still not an issue:
Jou need at least two activitys and it is the bottom navigation
Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht -------- Van: Gareth J Barnard notifications@github.com Datum: 21-12-18 18:22 (GMT+01:00) Aan: gjb2048/moodle-theme_essential moodle-theme_essential@noreply.github.com Cc: Gemma Lesterhuis gemma@ltnc.nl, Author author@noreply.github.com Onderwerp: Re: [gjb2048/moodle-theme_essential] Activity navigation - contrast issue (#889)
Still not an issue:
[e889_2]https://user-images.githubusercontent.com/1058419/50354917-f2be8d00-0544-11e9-951a-ef2a2dcbade0.png
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/889#issuecomment-449447332, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APyvfwN91pSM-tsDqJseCL_HswBefmy7ks5u7RjGgaJpZM4ZeRkB.
I do have two activities and there is no 'bottom navigation'.
Ok, forgot about 'activitynavigationposition'.
Ok, with many activities and bottom navigation:
and still not a problem.
Ok i am going to check other thingz
Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht -------- Van: Gareth J Barnard notifications@github.com Datum: 21-12-18 18:34 (GMT+01:00) Aan: gjb2048/moodle-theme_essential moodle-theme_essential@noreply.github.com Cc: Gemma Lesterhuis gemma@ltnc.nl, Author author@noreply.github.com Onderwerp: Re: [gjb2048/moodle-theme_essential] Activity navigation - contrast issue (#889)
Ok, with many activities and bottom navigation:
[e889_3]https://user-images.githubusercontent.com/1058419/50355464-b0964b00-0546-11e9-8c3a-3a3fbeedd169.png
and still not a problem.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/889#issuecomment-449450512, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APyvf-OtxxIEc9juO9dAvZo3t1LXLe75ks5u7RuzgaJpZM4ZeRkB.
Even if I manually manipulate a link on the frontpage to have the same markup and attribute structure (and turn off the additional custom CSS) on the same site, then still not a problem:
Hi Gem,
Could you provide the properties export of the site please?
Gareth
hi Gareth,
I am happy with your hands-on-approach ;-)
Enclosed you find the porperties export. Today I am investigating this issue a bit further. Because It could be a plugin that is bugging out on me. Since I have it on multiple sites. Ontwikkelversneller.txt
Gemma
Hi gareth,
I am sure now it is a plugin that is bugging.
I have no issues on my own learning environment but have a few sites with plugins I do not use there. I am going to sort out which one it is, but it is NOT an Theme issue
Gem
Hi Gem,
I concur, as this is what I get:
What additional plugins are installed?
Gareth
Hi Gareth,
It is a long list of additional plugins. I crossed referenced my learning sites using Essential vs additional plugins. And at the moment my conclusion is, that is one of the custom made plugins both are using. I cannot conduct further investigation since these are not available on moodle.org ór public github.
That’s why I closed this ticket.
Gem
Van: Gareth J Barnard notifications@github.com Verzonden: Sunday, December 23, 2018 17:06 Aan: gjb2048/moodle-theme_essential moodle-theme_essential@noreply.github.com CC: Gemma Lesterhuis gemma@ltnc.nl; State change state_change@noreply.github.com Onderwerp: Re: [gjb2048/moodle-theme_essential] Activity navigation - contrast issue (#889)
Hi Gem,
I concur, as this is what I get:
[Afbeelding verwijderd door afzender. e889_5]https://user-images.githubusercontent.com/1058419/50385373-8ec6d080-06cc-11e9-9bd5-931244ad2464.png
What additional plugins are installed?
Gareth
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/gjb2048/moodle-theme_essential/issues/889#issuecomment-449645959, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APyvf4N6IZ7ZPu8Kp-4rSFPw126-bnpeks5u76nLgaJpZM4ZeRkB.
Ok.
Hi Gareth, I think it is a change endorsed by Moodle HQ that causes a conflict now with Essential Acitivty navigation.
I am using Moodle 3.5.3 with the latest version of Essential. Due to a change the contrast between text color - back ground is gone. It seems the created "buttons" for it?? See screenshot below
If fixed the issue now by adding a Custom css line:
activitynavigation .m-t-2 .btn-link {background-color:#0007!Important}
But well you can image that is a hell of a job to do with all the childtheme's running ;-)
I kind of open that you have a more elegant fix for the theme. I can imagine more people find them self with this issue.
Gem