gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 56 forks source link

Alignment of Grid images on the bottom row of a grid #188

Open KenFarr opened 1 year ago

KenFarr commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Versions you are currently using (please complete the following information):

Funding All new features / improvements need to be financially funded. There might be a few exceptions where I decide that I'll learn something new or want to add the functionality, but this will be on a case by case basis.

Hi Gareth As per email, I would like to request a feature that allows the user in each Moodle course using grid format to decide how grid format behaves if the bottom row is not not full. This has become more important as we use the Section breaks system so have the same issue after each section break. picture attached to show what I mean. On row three and row five of this grid I would like the option of images floating left.

thanks Ken

grid

gjb2048 commented 1 year ago

Dear @KenFarr,

I'm currently using 'space-between', please see https://css-tricks.com/snippets/css/a-guide-to-flexbox/#aa-justify-content - so technically there is only one row for a group of grid boxes, either with no or one or more section breaks. This is to allow the wrapping to work. Clearly if I use 'flex-start' or 'flex-end' then this will lead to space either to the right or the left, or at least an imbalance on one side. Would 'center' or 'space-around' in theory look better for you?

Kind regards,

Gareth

gjb2048 commented 1 year ago

E.g:

Screenshot 2023-08-16 132723 Screenshot 2023-08-16 133047 Screenshot 2023-08-16 133019 Screenshot 2023-08-16 132843

gjb2048 commented 1 year ago

Dear @KenFarr,

Related to: https://github.com/gjb2048/moodle-format_grid/issues/191/

Kind regards,

Gareth

gjb2048 commented 1 year ago

@KenFarr Please note a change in the URL -> https://github.com/gjbarnard/moodle-format_grid/issues/188

gjb2048 commented 1 year ago

@KenFarr This has now been implemented in #191 for M4.1+ versions. Do you require backporting to M4.0?

gjb2048 commented 5 months ago

@KenFarr Are you happy that this is complete please?