Grid format images displayed below and behind grid boxes

[dragos5436]

Describe the bug After our last Moodle upgrade we noticed that in courses where the grid format is in use, the images supposed to be inside the boxes are now displayed below the boxes and/or behind the boxes just below.

To Reproduce Steps to reproduce the behaviour:

1. Go to any course using the grid format or set the format to grid;
2. Scroll down to see the grid boxes;
3. Notice the misplaced images.

Expected behaviour Images should be displayed within the borders of the grid boxes.

Screenshots Here is an example of a course before and after the bug:

Before (expected behaviour):

After (current behaviour):

Versions (please complete the following information):

• Moodle: 4.4.2+ (Build: 20240823)
• Format: 2024032902
• Browser: Tested in the latest version of Chrome, Edge and Firefox, was able to replicate the issue in each one.

Additional context Some further digging revealed that the bug has been present since commit https://github.com/gjbarnard/moodle-format_grid/commit/bc5cb698c5da4945aef280f79ba12d2b2957e15b . Using any version before this resolves the issue and the images are in the right place.

1) Could you please investigate whether you are able to reproduce?

2) We have over 800 courses in our Moodle using this format and we are looking to get this sorted asap. Is there any quick fix we can apply (such as custom CSS for instance) before a proper solution is released?

Thank you.

Kind regards, Dragos

[gjb2048]

@dragos5436 Are you telling me that you're using a development non-released version on a production install?

[dragos5436]

Hi @gjb2048 , we are currently using the main branch of the grid format plugin in our production build. It currently has the same version as the one I mentioned above. The commit I was talking about was released on this branch on Aug 14th:

Are you saying this is a development branch and we should not be using it?

[gjb2048]

@dragos5436 Please read the 'Readme.md' file that comes with the format:

And I can't replicate with 'main' at commit https://github.com/gjbarnard/moodle-format_grid/commit/1502065bd4a5f05ae049290fb935cb6644a92c10.

[gjb2048]

Also what theme are you using?

[gjb2048]

And looking at / interpreting your screen shots then I think it is a theme issue / conflict.

[gjb2048]

And.... do you always update your production server without first updating your test server and checking there?

Given that I have and have done for quite some time stressed "This release could contain bugs and so I strongly recommend that you check on a test server first! Not sure how to set one up? Then look at the 'Installer packages' on https://download.moodle.org/releases/latest/. Ensure that you have multiple backups of all data before using. Please report any issues. i.e. 'bugs' with this release ONLY here. Before doing so please read 'Reporting issues' on the 'Information' tab on the course format 'Settings' under 'Site administration' -> 'Plugins' -> 'Course formats' -> 'Grid'.

Note: Always install on a test server to confirm that the format does what you want it to do before updating or installing on a production server.", e.g. https://moodle.org/mod/forum/discuss.php?d=459308.

[dragos5436]

Thank you for the information above. I think after the upgrade to Moodle 4.4 we switched the grid format branch from MOODLE_403 to main. Are you recommending we use, for instance, a tag such as 'V404.1.0' for Moodle 4.4?

We are currently using our own custom theme for UCL. You believe there is a conflict between that and the grid format that is causing this issue?

And yes, we do have test environments where we test updates before releasing to production, but we don't test every new update released by plugin developers. I assume the problem was we were not aware this was a development branch and did not worry about testing the work on it.

[gjb2048]

1. Always use tagged versions unless wanting to support me by occasionally testing what is being developed.
2. Yes.
3. You should test every update by a plugin developers as they / I, are / am only human.

[gjb2048]

My mistake, couldn't see the possibility of https://github.com/gjbarnard/moodle-format_grid/commit/9b12eaf1e0435156551e102b49b138a9060ea0ac being the cause.

[dragos5436]

Closing as fixed by subsequent commits