search

gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 56 forks source link

#217 - Grid format images displayed below and behind grid boxes #218

Closed Ardelean-Emanuel closed 2 months ago

Ardelean-Emanuel commented 2 months ago

217 Once you hide a section, the next sections will be displayed below the hidden section because of the missing div in grid.mustache

gjb2048 commented 2 months ago

@Ardelean-Emanuel Thanks for the spot, right idea, wrong solution -> https://github.com/gjbarnard/moodle-format_grid/commit/9b12eaf1e0435156551e102b49b138a9060ea0ac.

gjb2048 commented 2 months ago

I'm rejecting https://github.com/gjbarnard/moodle-format_grid/pull/218/commits/ab0f21438b94a4f34b7e1c96ce32ef2d4214c1ab as there was an underlying logic issue that was actually the casue.

gjb2048 commented 2 months ago

@Ardelean-Emanuel Reaching out to find out the purpose of the changes / commits please.