search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

The plugin should honor MDL-68330 change #74

Closed golenkovm closed 4 years ago

golenkovm commented 4 years ago

These lines should have mod-indent-outer w-100 class:

https://github.com/gjb2048/moodle-format_topcoll/blob/db00bdffc07209889dedcdc208ca0ae04a3f81d0/tests/courseformatrenderer_test.php#L284 https://github.com/gjb2048/moodle-format_topcoll/blob/db00bdffc07209889dedcdc208ca0ae04a3f81d0/tests/courseformatrenderer_test.php#L331 https://github.com/gjb2048/moodle-format_topcoll/blob/db00bdffc07209889dedcdc208ca0ae04a3f81d0/tests/courseformatrenderer_test.php#L378 https://github.com/gjb2048/moodle-format_topcoll/blob/db00bdffc07209889dedcdc208ca0ae04a3f81d0/classes/course_renderer.php#L176

gjb2048 commented 4 years ago

Additional to #74, if 'mod-indent-outer' has 'width: 100%' added to it in the CSS then none of the PHP, including the unit tests need to change! Simpler.

gjb2048 commented 4 years ago

Note M3.9+ thing.

gjb2048 commented 4 years ago

Patched with much simpler https://github.com/gjb2048/moodle-format_topcoll/commit/1b2b13fbec2ac1640a1a07764f5dd013d761220f.