search

gjtorikian / jekyll-last-modified-at

A Jekyll plugin to show the last_modified_at time of a post.
MIT License
241 stars 38 forks source link

add option `use-git-cache` which makes single `git log ...` call #87

Open klandergren opened 3 years ago

klandergren commented 3 years ago

This diff does two things:

  1. aligns path_cache behavior in determinator.rb so that both formatted and raw calls to last_modified_time are read from the path_cache

  2. adds option use-git-cache which improves render performance by reading the entire git log once (instead of 1:1 for each file)

More information available in #85

I did not test extensively but did verify that bundle exec rake spec passed. bundle exec rake rubocop reported an issue with Style/OptionalBooleanParameter which I did not think worth changing existing code to accommodate.

gjtorikian commented 1 month ago

👋 Unfortunately, my GitHub notifications for this repository was oddly turned off. I take my responsibility to accepting patches seriously; however, I am just one person, with a very busy life off of GitHub.com! I'm going to close this PR because I like to keep my TODO list scoped and reasonable. This does not mean I will not accept this patch! Rather, it's a way of me asking you if you're still using this gem, and whether you want this PR merged. Just comment back and I'll prioritize it. I assume silence means I can keep it closed. Thanks!

this was an automated copy-paste

khemarato commented 1 month ago

I'm still using this PR

khemarato commented 1 month ago

Sorry, should have mentioned: I built on this PR in #91 - If you just merge 91, it should come with this functionality... up to you how to handle it 😊