search

gkdr / libomemo

Implements OMEMO in C.
MIT License
55 stars 16 forks source link

Add missing symlinks libomemo.so.$(VER_MAJ) and libomemo.so #34

Closed hartwork closed 3 years ago

hartwork commented 3 years ago

Hi!

I use this patch in Gentoo packaging of libomemo. My interest is to get this patch (or some form of this patch) applied upstream so that (1) others can get the patch out of the box and (2) my own patch count downstream in Gentoo goes back to zero, e.g. to reduce the risk of merge conflicts with the next upstream release…

What do you think about the patch?

Best

Sebastian

PS: This pull request has a sibling at https://github.com/gkdr/axc/pull/24

hartwork commented 3 years ago

@gkdr any thoughts?

gkdr commented 3 years ago

hi @hartwork, thanks for the patch. my thoughts are that i'm sorry that i didn't have time to look at this yet :grimacing: your contribution does sound useful, the only issue is on my side: i don't know how to check whether it works as intended so i'd have to search the internet for a bit.

@fortysixandtwo, you originally contributed the feature. could you maybe help me speed this up with your expert knowledge? :slightly_smiling_face:

fortysixandtwo commented 3 years ago

Looks good and let's us get rid of explicitly doing the symlinks in Debian too: https://salsa.debian.org/DebianOnMobile-team/libomemo/-/blob/debian/master/debian/rules#L26

hartwork commented 3 years ago

Cool!

gkdr commented 3 years ago

thanks a lot, both of you!