glam-lab / degender-the-web

A Chrome extension that replaces all gendered pronouns with "they/them/their."
GNU Affero General Public License v3.0
6 stars 3 forks source link

It should show changes/highlights only when requested by the user #91

Closed ProfJanetDavis closed 5 years ago

ProfJanetDavis commented 5 years ago

Is your feature request related to a problem? Please describe. This redesign/refactoring will resolve issues #15, #63, #86.

Describe the solution you'd like

Describe alternatives you've considered I considered putting the original tooltips back (#6). That would serve transparency less well, since you would only be able to see one change at a time. That would also require more extensive modifications to the diff implementation above.

Rationale This approach will make changes more visible and easier to read when the user asks to see them, and totally invisible otherwise.

This approach will separate markup from natural language processing, resulting in more modular and readable code.

Implementation plan This will be a significant, user-visible change requiring changes to both unit tests and end-to-end tests. Practice test-driven development!

Additional context Since it involves the header buttons, this issue will interact with #68. There are no particular implications for implementation order, but whichever is completed later will need to account for the one completed first.

ProfJanetDavis commented 5 years ago

@irhawk, what do you think of this proposal?

beszel commented 5 years ago

This solution seems fine, I can't think of a better way to show changes. Could you tell me about when the user needs the diff mode? I like it for debugging; does it also help with transparency?

ProfJanetDavis commented 5 years ago

Yes, it's important that users be able to understand what the algorithm has changed. Being able to restore the original text goes some distance toward that, but people are not very good at comparing texts in their head.

Thanks!