glamod / glamod-nuim

NUIM code in support of GLAMOD
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

daily_csv_to_cdm_utils.py value_significance error for snow depth #73

Closed sjnoone closed 1 year ago

sjnoone commented 1 year ago

Need to fix value_significance coding error in daily_csv_to_cdm_utils.py where observed variables 53 should be 12 instantenous as below and not 13 not accumulation as in .py file

VALUE_SIGNIFICANCE = { "SNWD" : "12", "PRCP" : "13", "TMIN" : "1", "TMAX" : "0", "TAVG" : "2", "SNOW" : "13", "AWND" : "2", "AWDR" : "2", "WESD" : "13", }

this will be fixed directly in r.02 database by Alastair and r.06 daily data re-run

sjnoone commented 1 year ago

Also can we check the montghly_to _cdmv1.py that all value significnace are set to correct codes?

rjhd2 commented 1 year ago

Good spot - another reason why we want to link these directly to the tables in the CDM definition. Something to look up after this release.

For the monthly I've done as for the daily and abstracted into a dictionary. Do check I've got those correctly - as SNOW and SNWD both exist, as well as WESD, which when coming back to this aren't entirely clear as to how their definitions differ.

sjnoone commented 1 year ago

Thanks Robert , the changes look good. Simon