glenjamin / transit-immutable-js

Transit serialisation for Immutable.js
MIT License
250 stars 31 forks source link

Module not found: Error: Can't resolve 'transit-js' in 'transit-immutable-js' #34

Closed alexicum closed 7 years ago

alexicum commented 7 years ago

Installing transit-immutable-js not installing transit-js

ERROR in ./~/transit-immutable-js/index.js
Module not found: Error: Can't resolve 'transit-js' in '[project-root]\node_modules\transit-immutable-js'
 @ ./~/transit-immutable-js/index.js 1:14-35
 @ ./app/store/localStorage.js
 @ ./app/app.js
glenjamin commented 7 years ago

https://github.com/glenjamin/transit-immutable-js/blob/master/package.json#L21-L24

I imagine there's a peerDependency warning from npm you're ignoring somewhere?

alexicum commented 7 years ago

Yes:

warning "transit-immutable-js@0.7.0" has unmet peer dependency "transit-js@>= 0.8".
warning "babel-plugin-rewire@1.0.0" has unmet peer dependency "babel-template@^6.2.0".
warning "babel-plugin-rewire@1.0.0" has unmet peer dependency "babel-types@^6.2.0".

Do I need install them manually?

glenjamin commented 7 years ago

Yep, since npm 3 peer dependencies have to be manually selected and installed.

smmoosavi commented 7 years ago

I think we should change npm install transit-immutable-js to npm install transit-js transit-immutable-js to readme.