glideinWMS / glideinwms

The glideinWMS Project
http://tinyurl.com/glideinwms
Apache License 2.0
16 stars 45 forks source link

project_id does not work with scitokens #264

Closed mmascher closed 1 year ago

mmascher commented 1 year ago

Describe the bug Colby reported the factory was not sending pilots to an entry that was supposed to use scitoken+projectid as auth_method. Found this exception in the entry logfile in the factory:

  File "/usr/lib/python3.6/site-packages/glideinwms/factory/glideFactoryLib.py", line 2018, in get_submit_environment
    glidein_rsl = "{}(project={})".format(glidein_rsl, submit_credentials.identity_credentials["ProjectId"])
KeyError: 'ProjectId'

To Reproduce Setup an entry with scitoken+projectid, use that auth method in the frontend and try to submit.

Expected behavior Pilots should be submitted with no exception

Info (please complete the following information):

mmascher commented 1 year ago

This has been already deployed to the UCSD factory. Waiting for colby to confirm it fixed the issue

mmascher commented 1 year ago

It works, confirmed on slack