Closed mambelli closed 1 year ago
Minor changes suggested.
Note: The failing pylint build check was discussed as a known problem, but based on Marco's understanding, this is expected to be resolved once the changes get merged with the main branch.
Locally is completing successfully all unit tests. Before the time rotation was timing out. The culprit was the maxDays
value converted to int. The specs in the class were not clear. Fractions of a day (float) are OK and used to run the unit test in a reasonable time.
Added changes to support structured logs:
logSupport
Structured logs are disabled by default to ease the transition. They can be enabled by adding
structured="True"
to the configuration of the logs (process_log
sections in the Factory and Frontend configurations)Added also some general improvements: cleanup of comments and docstrings, consolidation of
util.is_true()
, and fixed a couple of small bugs.The first commits are by @MissAnita2
This PR replaces PR #327 because GitHub got confused from the rebase eliminating the HTML files changes. And that PR replaced Anita's PR #325 because I reverted once the automatic unrelated changes to all HTML files and was unable to force-update when they were re-applied
Suggestions from @namrathaurs review of PR #327 have been applied