search

glimmerjs / glimmer-blueprint

[MOVED] This package is now part of the Glimmer.js monorepo
https://github.com/glimmerjs/glimmer.js
25 stars 13 forks source link

Add ordered-imports false rule to tslint.json #75

Closed geekygrappler closed 6 years ago

geekygrappler commented 6 years ago

Glimmer blueprint itself is fine on this rule, but component blueprint ember g glimmer-component Foo will cause tslint to error on the components test file. Happy to submit a PR to change the glimmer-component blue print instead if we want to keep this rule.

Personally I don't think alphabetising imports is that rad, which is why I submitted this PR first. ✌️

🎅 Merry Christmas 🎄

t-sauer commented 6 years ago

I think the recommended preset of TSLint is pretty bad in general since it includes a huge amount of stylistic rules like this one. I would prefer a preset that works like the recommended one of ESLint (basically no stylistic opinions at all) but I haven't found one yet.