Closed dfreeman closed 1 year ago
@chriskrycho @dfreeman Just wondering whats left to do here as it seems like this is the last PR to remove the glimmerx re-exports in glint.
I think all that's needed here is a merge and release from a maintainer. Once that's done we'll need to make some corresponding changes in @glint/environment-glimmerx
and publish a new release of that as well.
I merged this but looks like the tests are failing on master, not just the ember ones that I think were failing before this.
Looks like an outdated Babel version. I'll see if I can get a PR together to get tests green more generally
@chadhietala things should be ✅ across the board in https://github.com/glimmerjs/glimmer-experimental/pull/154
@dfreeman 0.6.7 is released with these changes
@chadhietala Thanks! Hopefully we should be able to get an updated @glint/environment-glimmerx
out in the next week or two
This PR proposes a few changes to the types in order to provide tools like Glint the hooks necessary to augment them with additional information for template validation. In particular, it:
on
andfn
using the same approach as https://github.com/DefinitelyTyped/DefinitelyTyped/pull/58606hbs
andhelper()
, following the same approach as https://github.com/DefinitelyTyped/DefinitelyTyped/pull/59714It also adds a very basic type test suite using
expect-type
Ping (low urgency) @chriskrycho for a sanity-check 🙂