glimmerjs / glimmer-experimental

A set of experimental high-level APIs built on Glimmer.js
https://glimmerjs.github.io/glimmer-experimental/
58 stars 26 forks source link

Update types for extensibility #148

Closed dfreeman closed 1 year ago

dfreeman commented 2 years ago

This PR proposes a few changes to the types in order to provide tools like Glint the hooks necessary to augment them with additional information for template validation. In particular, it:

It also adds a very basic type test suite using expect-type

Ping (low urgency) @chriskrycho for a sanity-check 🙂

chadhietala commented 1 year ago

@chriskrycho @dfreeman Just wondering whats left to do here as it seems like this is the last PR to remove the glimmerx re-exports in glint.

dfreeman commented 1 year ago

I think all that's needed here is a merge and release from a maintainer. Once that's done we'll need to make some corresponding changes in @glint/environment-glimmerx and publish a new release of that as well.

chadhietala commented 1 year ago

I merged this but looks like the tests are failing on master, not just the ember ones that I think were failing before this.

dfreeman commented 1 year ago

Looks like an outdated Babel version. I'll see if I can get a PR together to get tests green more generally

dfreeman commented 1 year ago

@chadhietala things should be ✅ across the board in https://github.com/glimmerjs/glimmer-experimental/pull/154

chadhietala commented 1 year ago

@dfreeman 0.6.7 is released with these changes

dfreeman commented 1 year ago

@chadhietala Thanks! Hopefully we should be able to get an updated @glint/environment-glimmerx out in the next week or two