glimmerjs / glimmer-vm

MIT License
1.13k stars 191 forks source link

delegate modifiers debug name & instance #1591

Open patricklx opened 5 months ago

patricklx commented 5 months ago

currently arrow functions or functions without name are displayed with their whole implementation source code

closes #1589

NullVoxPopuli commented 5 months ago

what will this look like?

patricklx commented 5 months ago

what will this look like?

{{my-modifier fn}} is how it can look like.

Currently... look at you limber site :) it's a good example

NullVoxPopuli commented 5 months ago

I see! image

looks like anything that fixes this is good for me

patricklx commented 4 months ago

@NullVoxPopuli actually, current release of inspector cannot handle latest ember... need nightly:

Screenshot 2024-06-27 at 10 39 38
wycats commented 4 months ago

This looks good to me. Let's do it!

NullVoxPopuli commented 1 month ago

Seems good image