search

globality-corp / flake8-logging-format

Flake8 extension to validate (lack of) logging format strings
Apache License 2.0
134 stars 21 forks source link

Version 2024.24.12 on pypi? #77

Open priv-kweihmann opened 2 weeks ago

priv-kweihmann commented 2 weeks ago

On pypi a version 2024.24.12 can be found, also labelled as the latest - shadowing the, I hope, indented 1.0.0 version.

To my surprise I don't find any information here about that version, nor tags for 1.0.0 and that version.

Was that intended? Could you please create tags for each release? Could the 2024.24.12 please be yanked on pypi? Could you please upload sdist artifacts to pypi again?

jonyscathe commented 2 weeks ago

Looking at the PR on switch to drone and py3.11's .drone.yml file this all looks intentional: https://github.com/globality-corp/flake8-logging-format/pull/73/files#diff-b54b39f1afced2465e1f3641db9d5bbf4f3a7fcf890996dfedd3c197bcb7f8c7

Look to be setting the version to '/bin/date +%Y.%-V'.${DRONE_BUILD_NUMBER} which has a major of year, minor of week number of the year, and subminor of build number.

But I agree, some documentation change to explain what the new versioning scheme and that this is an intentional change would be nice... As well as something stating what the changes in the release are given that it had a major version bump which could worry some people about potential breaking changes.

Though as far as I can see, they've just changed the build/CI system and done a little linting.

priv-kweihmann commented 6 days ago

@lfmoisa-globality can you comment on above things?