search

globalizejs / globalize

A JavaScript library for internationalization and localization that leverages the official Unicode CLDR JSON data
https://globalizejs.com
MIT License
4.8k stars 602 forks source link

Test: Support testing a range of CLDR versions #427

Open rxaviers opened 9 years ago

rxaviers commented 9 years ago

Currently, we run our unit and functional tests against the latest CLDR version.

First, we should raise the pros and cons of having tests executed for all supported CLDR versions, e.g., CLDR 25, CLDR 26, CLDR 27. Then, implement it.

scottgonzalez commented 9 years ago

Well, this is going to show you two things: When data changes and when syntax changes. Data changes shouldn't concern Globalize. Syntax changes will be noticed when updating which version of CLDR we're using, if tests start to break.

However, the one benefit of testing older versions is that new functionality may not work with old CLDR data, and the easiest way to find that out is to test against the older data. I'd suggest having a nightly or weekly test for old versions, but only testing against the latest version for PRs and pushes.

rxaviers commented 9 years ago

:+1: