search

glossarist / iev-data

1 stars 1 forks source link

Switch to Glossarist gem #189

Closed skalee closed 3 years ago

skalee commented 3 years ago

Concept models are now maintained in Glossarist gem. This pull request removes old logic from IEV termbase generator and replaces it with calls to Glossarist API.

Fixes glossarist/glossarist-ruby#1.

ronaldtse commented 3 years ago

@skalee thank you! Please merge when ready 👍

skalee commented 3 years ago

These test failures are odd. They don't happen locally. Need to investigate.

skalee commented 3 years ago

Subtle Glossarist's incompatibility with Ruby 2.6. Reasons:

Later I'll create a proper fix for Glossarist gem. For now I'll rather upgrade Ruby in this project.

ronaldtse commented 3 years ago

@skalee FYI that @opoudjis will be using this gem in Metanorma in the next 2 weeks. Metanorma is currently bound to Ruby 2.4, so we will have to make the compatibility change.

skalee commented 3 years ago

Metanorma is currently bound to Ruby 2.4, so we will have to make the compatibility change.

Yes, I know this requirement. Compatibility fix is easy, it's just using Hash#merge instead of double splat. However, apparently tests are insufficient or incorrect, moreover I may need to add some constraints or coercions to prevent from using incorrect objects as language codes.