glotzerlab / hoomd-blue

Molecular dynamics and Monte Carlo soft matter simulation on GPUs.
http://glotzerlab.engin.umich.edu/hoomd-blue
BSD 3-Clause "New" or "Revised" License
343 stars 132 forks source link

Ensure that partitions have different seeds in MuVT. #1925

Closed joaander closed 3 weeks ago

joaander commented 3 weeks ago

Description

Ensure that users select different seeds for partitions in MuVT Gibbs groups. Use the seed from the root of the group for random numbers that must be the same across the group.

Motivation and context

Prior to this change MuVT required that users choose the same seed for all partitions participating in the same Gibbs ensemble group. Doing so results in correlated local moves in the separate simulation boxes.

How has this been tested?

I tested the fix locally. Setting identical seeds within the Gibbs groups causes the error. Setting different seeds no longer causes an MPI_Recv error.

Checklist: