Closed xacobofg closed 2 years ago
cconard96
commented
2 years ago Those hooks are only implemented for the tabs on forms. What is the expected behavior for these hooks when used with the timeline items? The "pre_item_form" and "post_item_form" hooks are implemented for the timeline items.
xacobofg
commented
2 years ago The hooks for the tabs should be "pre_show_tab" and "post_show_tab". An example of use for these hooks can be found in the Actualtime plugin. I use the hook "post_show_item" to show the plugin time in the task without having to open it. I don't know if there is now another way to add extra information in the tasks or followups.
Aeto-J
commented
2 years ago The same problem for me with 'pre_show_item' and 'pre_item_form' / 'post_item_form' are missing in 'simple_form.Html.Twig', so we can't use either of them in a plugin that uses simple_form as main_description ticket editing form for example.
cedric-anne
commented
2 years ago @xacobofg @Aeto-J
Can you validate that #12265 is OK for your needs ?
xacobofg
commented
2 years ago Hello @cedric-anne.
Sorry for taking so long to reply.
I tested the change and it works correctly
Code of Conduct
Is there an existing issue for this?
Version
10.0.1
Bug description
When a plugin wants to use the 'pre_show_item' and 'post_show_item' hooks they are not activated by the TicketTask, ITILFollowup and ITILSolution elements. This fails on changes, problems and tickets.
Relevant log output
No response
Page URL
No response
Steps To reproduce
Your GLPI setup information
Information about system installation & configuration
Server
Operating system: Linux testing01.tic.gal 5.4.0-100-generic #113-Ubuntu SMP Thu Feb 3 18:43:29 UTC 2022 x86_64 PHP 8.0.14 fpm-fcgi (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apcu, bcmath, bz2, calendar, cgi-fcgi, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imagick, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, pspell, readline, session, shmop, soap, sockets, sodium, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="900" memory_limit="256M" post_max_size="50M" safe_mode="" session.save_handler="files" upload_max_filesize="50M" Software: Apache/2.4.52 (Ubuntu) mod_fcgid/2.3.9 OpenSSL/1.1.1f () Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36 Server Software: mariadb.org binary distribution Server Version: 10.6.5-MariaDB-1:10.6.5+maria~focal Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: glpi10_glpirw@localhost/glpi10_glpidb Host info: Localhost via UNIX socket PHP version (8.0.14) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed. gd extension is installed. intl extension is installed. libxml extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.6.5) is supported. The log file has been created successfully. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_cache has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/config has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_cron has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_dumps has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_graphs has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_lock has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_pictures has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_plugins has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_rss has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_sessions has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_tmp has been validated. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/files/_uploads has been validated. Web access to files directory is protected exif extension is installed. ldap extension is installed. openssl extension is installed. zip extension is installed. bz2 extension is installed. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /home/glpi10/web/glpi10.tic.gal/public_html/marketplace has been validated. Access to timezone database (mysql) is not allowed.GLPI constants
Libraries
SQL replicas
Notifications
Plugins list
example Name: Plugin Example Version: 0.0.1 State: EnabledAnything else?
No response