Add User itemtype to Licenses linked items

glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.

https://glpi-project.org

GNU General Public License v3.0

4.36k stars 1.3k forks source link

Add User itemtype to Licenses linked items #18335

Open RomainLvr opened 1 week ago

RomainLvr commented 1 week ago

Checklist before requesting a review

Please delete options that are not relevant.

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my code.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] This change requires a documentation update.

Description

It fixes !34567
Here is a brief description of what this PR does

Adding the relationship of Licenses and Contracts to Users

Linked with #18388

Screenshots (if appropriate):

Licenses :

Contracts :

AdrienClairembault commented 1 week ago

The discussion in #13294 seems to to indicate that this feature was refused last time.

I've also found this on our gitlab: https://gitlab.teclib.com/editions/projects/features-request/-/issues/133

cconard96 commented 1 week ago

AFAIK this still hasn't been planned out and there is so much related to license management that people have been asking for for years that just isn't possible yet. It only really makes sense to me to do a complete rework.

orthagh commented 3 days ago

I don't remember at all the reason why #13294 was refused. After checking, the important point is the summary tab and the countdown of used licenses and this seems to work correctly.

Maybe there are issues (I didn't check) with linking entities of users, which are managed differently than in other objects. Also, if we start adding more objects to licenses, we need a dedicated CFG_GLPI constant.

As Curtis says, we still should rework licenses and at least decouple them from software itemtype, but regarding assignments to users, I don't see UX issues. As said above, there may exist technical problems.