search

glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.36k stars 1.3k forks source link

Simplify url validation regex and allow pluses #18365

Closed cconard96 closed 1 week ago

cconard96 commented 1 week ago

Checklist before requesting a review

Description

Fixes #18292 Pluses in a URL are allowed to be present unencoded to denote a space.

trasher commented 1 week ago

I'd agree to use an existing, well tested solution.

cconard96 commented 1 week ago

Just FYI, "parse_url" isn't reliable if it isn't a valid url to begin with according to the PHP docs.