glromeo / esbuild-sass-plugin

esbuild plugin for sass
MIT License
155 stars 40 forks source link

Is it possible to publish a new version without the src directory published? #190

Closed mattlewis92 closed 2 weeks ago

mattlewis92 commented 2 weeks ago

Hi there! I just upgraded to the latest version of this plugin and running into some issues due to the src directory being published to npm: CleanShot 2024-11-14 at 15 18 13@2x

Typescript is trying to typecheck these files and throwing errors. Is it possible to publish a new version without the src directory?

> cross-env NODE_OPTIONS='--max_old_space_size=16384' "tsc" "--noEmit" "-p" "tsconfig-test-typecheck.json"

node_modules/.pnpm/esbuild-sass-plugin@3.3.1_esbuild@0.24.0_sass-embedded@1.80.7/node_modules/esbuild-sass-plugin/src/render.ts:8:29 - error TS2307: Cannot find module 'sass/types/options' or its corresponding type declarations.

8 import {StringOptions} from 'sass/types/options'
                              ~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/esbuild-sass-plugin@3.3.1_esbuild@0.24.0_sass-embedded@1.80.7/node_modules/esbuild-sass-plugin/src/render.ts:9:29 - error TS2307: Cannot find module 'sass/types/compile' or its corresponding type declarations.

9 import {CompileResult} from 'sass/types/compile'
                              ~~~~~~~~~~~~~~~~~~~~

Found 2 errors in the same file, starting at: node_modules/.pnpm/esbuild-sass-plugin@3.3.1_esbuild@0.24.0_sass-embedded@1.80.7/node_modules/esbuild-sass-plugin/src/render.ts:8

Thank you!

mattlewis92 commented 2 weeks ago

Actually nevermind, found the issue was I was importing from esbuild-sass-plugin/src by accident