search

gltf-rs / gltf

A crate for loading glTF 2.0
Apache License 2.0
536 stars 124 forks source link

Relax proxy lifetimes #264

Closed Ralith closed 5 years ago

Ralith commented 5 years ago

Previously, every accessor method borrowed directly from its object, which makes certain traversals difficult. Instead, we can thread through a single same lifetime representing the root Gltf object.

Only updated Scene for now; this should probably be done pervasively, but I didn't want to put in the grunt work without buy-in.

alteous commented 5 years ago

Thanks for the PR! As you point out, this partly resolves the long standing lifetime issue.